[ML] Clear the change point test window on force_time_shift - #3221
Merged
valeriy42 merged 5 commits intoSep 25, 2026
Merged
Conversation
|
Pinging @elastic/ml-core (Team:ML) |
valeriy42
added
auto-backport
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
elastic-vault-github-plugin-prod Bot
added a commit
that referenced
this pull request
Sep 25, 2026
…3223) ## Summary #3209 stopped clearing the change-point test window inside `reset()` so a level change that also triggers seasonality detection keeps the pre-change samples. `force_time_shift` still goes through `resetChangePointTest`, which only called `reset()`, so samples recorded on the old clock stayed in the window. `resetChangePointTest` now calls `resetAfterTimeShift`, which clears the window and then resets the error moments. `reset()` and the seasonal handler are unchanged. (cherry picked from commit e3ae484) Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
elastic-vault-github-plugin-prod Bot
added a commit
that referenced
this pull request
Sep 25, 2026
…3222) ## Summary #3209 stopped clearing the change-point test window inside `reset()` so a level change that also triggers seasonality detection keeps the pre-change samples. `force_time_shift` still goes through `resetChangePointTest`, which only called `reset()`, so samples recorded on the old clock stayed in the window. `resetChangePointTest` now calls `resetAfterTimeShift`, which clears the window and then resets the error moments. `reset()` and the seasonal handler are unchanged. (cherry picked from commit e3ae484) Co-authored-by: Valeriy Khakhutskyy <1292899+valeriy42@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#3209 stopped clearing the change-point test window inside
reset()so a level change that also triggers seasonality detection keeps the pre-change samples.force_time_shiftstill goes throughresetChangePointTest, which only calledreset(), so samples recorded on the old clock stayed in the window.resetChangePointTestnow callsresetAfterTimeShift, which clears the window and then resets the error moments.reset()and the seasonal handler are unchanged.