Repository navigation
[GEF] Use absolute coordinates for PaletteComposite - #1664
Merged
ptziegler merged 1 commit intoOct 6, 2026
Merged
Conversation
With cedfc14, the coordinate transformation in our Figure is no longer applied to the palette, which causes the categories and entries to be drawn outside the visible area. By adapting the `PaletteFigure` to extend the Draw2D `Figure` directly, we are now using exclusively Draw2D figure and thus can simply use absolute coordinates.
ptziegler
force-pushed
the
gef-palette-figures
branch
from
October 6, 2026 04:43
bb04fe8 to
c0a34fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With cedfc14, the coordinate transformation in our Figure is no longer applied to the palette, which causes the categories and entries to be drawn outside the visible area.
By adapting the
PaletteFigureto extend the Draw2DFiguredirectly, we are now using exclusively Draw2D figure and thus can simply use absolute coordinates.