Skip to content

[GEF] Remove IPreferredSizeProvider in TopFigure - #1663

Open
ptziegler wants to merge 1 commit into
eclipse-windowbuilder:masterfrom
ptziegler:gef-preferred-size-provider2
Open

ptziegler wants to merge 1 commit into
eclipse-windowbuilder:masterfrom
ptziegler:gef-preferred-size-provider2

Conversation

@ptziegler

Copy link
Copy Markdown
Contributor

The preferred size of the TopFigure is determined by the size of children. Rather than implementing a generic provider, the StackLayout can be used instead.

Note that the preferred size of the root figure is now also derived from the preferred size of its children, together with their location.

The preferred size of the TopFigure is determined by the size of
children. Rather than implementing a generic provider, the `StackLayout`
can be used instead.

Note that the preferred size of the root figure is now also derived from
the preferred size of its children, together with their location.
@ptziegler ptziegler added this to the 1.26.0 milestone Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Test Results

     2 files   -      2       2 suites   - 2   1h 0m 45s ⏱️ - 1h 2m 57s
 7 019 tests ±     0   6 954 ✅  -     34  36 💤 + 6  29 ❌ +29 
11 840 runs   - 11 840  11 736 ✅  - 11 847  54 💤  - 42  50 ❌ +50 

For more details on these failures, see this check.

Results for commit 512f16f. ± Comparison against base commit 739eedc.

This pull request skips 6 tests.
org.eclipse.wb.tests.designer.rcp.model.rcp.PageLayoutGefTest ‑ test_fastviewShortcutsBounds
org.eclipse.wb.tests.designer.rcp.model.rcp.PageLayoutTest ‑ test_fastView_CREATE_1
org.eclipse.wb.tests.designer.rcp.model.rcp.PageLayoutTest ‑ test_fastView_CREATE_2
org.eclipse.wb.tests.designer.rcp.model.rcp.PageLayoutTest ‑ test_fastView_MOVE_1
org.eclipse.wb.tests.designer.rcp.model.rcp.PageLayoutTest ‑ test_fastView_MOVE_2
org.eclipse.wb.tests.designer.rcp.model.rcp.PageLayoutTest ‑ test_shortcuts_0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant