Repository navigation
Squint source maps - #54
Merged
Merged
Conversation
Contributor
Author
|
@rschmukler Once you're done reviewing, let me squash this PR to just one commit to not pollute history too much. |
rschmukler
approved these changes
Oct 14, 2026
rschmukler
left a comment
rschmukler
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Ready for squash and merge. Thanks!
borkdude
force-pushed
the
squint-source-maps
branch
from
October 14, 2026 16:45
fedb9a2 to
6fddb8f
Compare
Contributor
Author
|
Squashed! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rschmukler This PR adds source maps for defc components. They are off by default because including server side code might not be what you want in a production app. Pass
:source-map?true to create-handler to enable them. The example app does.To try it, throw an error in a defc body in
example/app.cljand look at the console: the stack trace points at the .clj line. With DevTools open, press Cmd-P and open example/app.clj. You can also just set breakpoints in there.