Conversation
maanavshah
approved these changes
Sep 10, 2026
Comment on lines
+44
to
+47
| if err := ensureOutputFileDir(e.OutputFile); err != nil { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
Similar bug could be seen here too- plugin/bitrise/bitrise.go at line 61. This has the same missing-parent-dir problem as the current GitHub Action output file did as godotenv.Write will fail here too if the directory doesn't exist.
Can we fix that too as a follow up if possible?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DRONE_OUTPUTwithout creating the parent directory (FileNotFoundErroronC:/Windows/TEMP/engine/...-output.env).os.makedirsin the Windows Python export script, andMkdirAllinExecerso Linuxecho > fileis covered too.Ticket
CI-24311