Use StructArmed on QA - #553
Merged
Merged
Conversation
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
force-pushed
the
use-structarmed-on-qa
branch
from
September 23, 2026 11:18
f9f4ea5 to
0d77728
Compare
Contributor
Author
|
Ready for review 👍 |
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
force-pushed
the
use-structarmed-on-qa
branch
from
September 23, 2026 11:38
a5d74fb to
280be41
Compare
Contributor
Author
|
Custom config github workflow is not needed since it already on laminas ci matrix which auto detect and github workflow already use it: StructArmed CI already runs on: https://github.com/dotkernel/api/actions/runs/35855676263/job/107164220643?pr=553 |
Contributor
Author
|
Ready for review 👍 |
Contributor
Author
|
@arhimede ready for review, qodana notice seems unrelated ;) |
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
alexmerlin
approved these changes
Sep 23, 2026
Member
|
thanks @samsonasik |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR add StructArmed to QA
https://github.com/boundwize/structarmed
It is a configurable PHP architecture guards with built in presets (psr4, mvc, and so on).
It already used by PHP frameworks:
This PR apply
StructArmedwith register:MustBeStaticAnonymousFunctionRuleto make usestaticwhen possibleCustom config github workflow is not needed since it already on laminas ci matrix
which auto detect
structarmed.phpconfig 👍and github workflow already use it:
api/.github/workflows/continuous-integration.yml
Line 11 in 3b5d001
StructArmed CI already runs on:
https://github.com/dotkernel/api/actions/runs/35855676263/job/107164220643?pr=553
Please let me know if this need simplification, reduce config, or split into multiple PRs.