Conversation
…oring Update healthcheck command from curl to wget (available in Alpine) and use port 8000 consistently, fixing unhealthy status in the sample guide. Fixes docker#26129 Signed-off-by: damian-sh <harryadonay62@gmail.com>
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the Go + Prometheus + Grafana guide (
content/guides/go-prometheus-monitoring.md), the sample API container failed its healthcheck and was reported asunhealthy.This PR fixes the following inconsistencies:
curlwithwget -qO- http://localhost:8000/healthin both Docker Compose examples and the descriptive explanation. The final runtime image is based onalpine:3.17, which includeswgetvia BusyBox out of the box, whereascurlis not installed.8000(the port exposed by the Dockerfile and listened on bymain.go), fixing a remaining reference to port8080.A corresponding pull request has also been submitted to the sample repository: dockersamples/go-prometheus-monitoring#1
Related issues or tickets
Fixes #26129
Reviews