test(e2e): fix TestPullFailure's daemon-specific error assertion - #14245
Merged
Merged
Conversation
ricardobranco777
marked this pull request as draft
September 21, 2026 07:10
ricardobranco777
force-pushed
the
fix_TestPullFailure
branch
from
September 21, 2026 07:24
a0b3d2e to
6018e38
Compare
The exact pull-failure wording is daemon-backend dependent (classic graphdriver: "pull access denied for ..."; containerd image store: "...: not found"), and OutputMatches only checks stdout while the daemon's progress line is written to stderr. Assert the image name appears on stderr instead, which holds regardless of backend or wording. Signed-off-by: Ricardo Branco <rbranco@suse.de>
ricardobranco777
force-pushed
the
fix_TestPullFailure
branch
from
September 21, 2026 07:41
6018e38 to
059cc11
Compare
ricardobranco777
marked this pull request as ready for review
September 21, 2026 07:51
Contributor
Author
|
Verification run: https://openqa.opensuse.org/tests/6230001 |
glours
enabled auto-merge (rebase)
September 23, 2026 14:04
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
The exact pull-failure wording is daemon-backend dependent (classic graphdriver: "pull access denied for ..."; containerd image store: "...: not found"), and OutputMatches only checks stdout while the daemon's progress line is written to stderr. Assert the image name appears on stderr instead, which holds regardless of backend or wording.
Otherwise test fails in openQA like this:
https://openqa.opensuse.org/tests/6229600/logfile?filename=docker_compose-e2e-compose.txt
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did