Skip to content

fix(windows): resolve System32 tar without relying on PATH - #29

Open
AKzar1el wants to merge 2 commits into
devnoname120:mainfrom
AKzar1el:fix/windows-system32-tar-20261117
Open

AKzar1el wants to merge 2 commits into
devnoname120:mainfrom
AKzar1el:fix/windows-system32-tar-20261117

Conversation

@AKzar1el

Copy link
Copy Markdown
Contributor

Summary

Use Windows' OS-bundled System32\tar.exe for browser companion packaging and artifact smoke extraction, rather than relying on a shell or nvm installation preserving System32 in PATH. Non-Windows platforms keep invoking tar unchanged.

The shared helper checks that the Windows root is absolute and that the binary exists; it never silently substitutes an unrelated executable from PATH.

Files

  • browser-companion/scripts/archive-tool.cjs: one small, tested platform-specific path resolver.
  • browser-companion/scripts/package.cjs and smoke-package.cjs: use the resolved executable with their existing arguments and staging policies.
  • browser-companion/tests/archive-tool.node.cjs: Windows path resolution, spaces in the path, missing tar, invalid relative root, and unchanged Unix behavior.

Verification (Windows)

  • node --test tests/archive-tool.node.cjs — 5 pass
  • bun test tests/package-stage.test.ts — 4 pass
  • node --check for all three packaging scripts — pass
  • Actual tar.exe --version using the resolved absolute path with empty PATH — pass
  • git diff --check — pass

Independent of the two-lane goal pilot; no browser profiles, service processes, automation configuration, or native scheduler changed. Based on Codexify v2.4.0 main.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant