Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Windows' OS-bundled
System32\tar.exefor browser companion packaging and artifact smoke extraction, rather than relying on a shell or nvm installation preserving System32 inPATH. Non-Windows platforms keep invokingtarunchanged.The shared helper checks that the Windows root is absolute and that the binary exists; it never silently substitutes an unrelated executable from PATH.
Files
browser-companion/scripts/archive-tool.cjs: one small, tested platform-specific path resolver.browser-companion/scripts/package.cjsandsmoke-package.cjs: use the resolved executable with their existing arguments and staging policies.browser-companion/tests/archive-tool.node.cjs: Windows path resolution, spaces in the path, missing tar, invalid relative root, and unchanged Unix behavior.Verification (Windows)
node --test tests/archive-tool.node.cjs— 5 passbun test tests/package-stage.test.ts— 4 passnode --checkfor all three packaging scripts — passtar.exe --versionusing the resolved absolute path with empty PATH — passgit diff --check— passIndependent of the two-lane goal pilot; no browser profiles, service processes, automation configuration, or native scheduler changed. Based on Codexify v2.4.0
main.