Repository navigation
feat(ci): expose recorded job attempt step timings - #663
Conversation
864493e to
2839df9
Compare
There was a problem hiding this comment.
LGTM. This is a read-only depot ci steps command that follows the same pattern as the existing ci metrics and ci summary commands.
What was reviewed:
steps.go: the positional argument and--attemptcan't both be given, auth goes through the existingResolveTurnReadAuthhelper, and JSON output keeps absent timings separate from zero. Text output turns control characters into spaces.- The generated connect code: the
IsAtLeastVersion1_7_0check and theWithIdempotency/WithClientOptionsoptions work with the connect v1.15.0 pinned ingo.mod. sandbox_test.goadds the new call site to the turn-token list and the per-file call count.- I didn't run any build or tests.
Extended reasoning...
The change adds one read-only RPC (GetJobAttemptSteps), a thin API wrapper, a new CLI subcommand with tests, and regenerated protobuf and connect code. The new protobuf code adds only the new messages and shifts index tables, and the connect changes are limited to the version check and the new method. For auth, it reuses the existing turn-token read helper and registers the new call site in the sandbox test. It adds no new credential handling, and terminal output is sanitized. There are no CODEOWNERS files, no reviewer objections in the timeline, and the bug hunt ran until it stopped finding issues (dry_streak).


Add
depot ci steps <attempt-id>anddepot ci steps --attempt <attempt-id>with text and JSON output matchingGetJobAttemptSteps. Show step identities, execution counts, status, timestamps, and durations while preserving absent versus zero timings and identifying incomplete or truncated snapshots.Uses the step-timings API, with capture controlled by
ci-step-timings. Related API reference. Part of DEP-7878.