Skip to content

feat(ci): expose recorded job attempt step timings - #663

Merged
ImLunaHey merged 3 commits into
mainfrom
luna/dep-7878-step-timings
Nov 20, 2026
Merged

ImLunaHey merged 3 commits into
mainfrom
luna/dep-7878-step-timings

Conversation

@ImLunaHey

@ImLunaHey ImLunaHey commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Add depot ci steps <attempt-id> and depot ci steps --attempt <attempt-id> with text and JSON output matching GetJobAttemptSteps. Show step identities, execution counts, status, timestamps, and durations while preserving absent versus zero timings and identifying incomplete or truncated snapshots.

Uses the step-timings API, with capture controlled by ci-step-timings. Related API reference. Part of DEP-7878.

@linear-code

linear-code Bot commented Nov 4, 2026

Copy link
Copy Markdown

DEP-7878

@ImLunaHey
ImLunaHey force-pushed the luna/dep-7878-step-timings branch from 864493e to 2839df9 Compare November 17, 2026 10:05
@ImLunaHey ImLunaHey changed the title feat(ci): add command to export job attempt step timings feat(ci): expose recorded job attempt step timings Nov 20, 2026
@ImLunaHey
ImLunaHey marked this pull request as ready for review November 20, 2026 16:35

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk: medium. Approved. Cursor Bugbot completed successfully with no findings that require human review.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a read-only depot ci steps command that follows the same pattern as the existing ci metrics and ci summary commands.

What was reviewed:

  • steps.go: the positional argument and --attempt can't both be given, auth goes through the existing ResolveTurnReadAuth helper, and JSON output keeps absent timings separate from zero. Text output turns control characters into spaces.
  • The generated connect code: the IsAtLeastVersion1_7_0 check and the WithIdempotency/WithClientOptions options work with the connect v1.15.0 pinned in go.mod.
  • sandbox_test.go adds the new call site to the turn-token list and the per-file call count.
  • I didn't run any build or tests.
Extended reasoning...

The change adds one read-only RPC (GetJobAttemptSteps), a thin API wrapper, a new CLI subcommand with tests, and regenerated protobuf and connect code. The new protobuf code adds only the new messages and shifts index tables, and the connect changes are limited to the version check and the new method. For auth, it reuses the existing turn-token read helper and registers the new call site in the sandbox test. It adds no new credential handling, and terminal output is sanitized. There are no CODEOWNERS files, no reviewer objections in the timeline, and the bug hunt ran until it stopped finding issues (dry_streak).

@ImLunaHey
ImLunaHey merged commit ad5eee4 into main Nov 20, 2026
13 checks passed
@ImLunaHey
ImLunaHey deleted the luna/dep-7878-step-timings branch November 20, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant