[fix] Put the validation error text into "message"

deckhouse/validations.py

@@ -43,4 +43,4 @@ def deny(self, message: typing.Union[str, None] = None):
         self.collect(response)
 
     def error(self, message: str):
-        self.collect({"allowed": False, message: f"Internal webhook error: {message}"})
+        self.collect({"allowed": False, "message": f"Internal webhook error: {message}"})

tests/validations_test.py

@@ -0,0 +1,26 @@
+from deckhouse import hook
+
+
+def run(handler):
+    return hook.testrun(handler).validations.data
+
+
+def test_allow():
+    assert run(lambda ctx: ctx.output.validations.allow()) == [{"allowed": True}]
+
+
+def test_allow_with_warnings():
+    data = run(lambda ctx: ctx.output.validations.allow("first", "second"))
+    assert data == [{"allowed": True, "warnings": ("first", "second")}]
+
+
+def test_deny():
+    data = run(lambda ctx: ctx.output.validations.deny("not allowed"))
+    assert data == [{"allowed": False, "message": "not allowed"}]
+
+
+def test_error_is_a_denial_with_the_message():
+    # shell-operator reads the reason from "message"; any other key is dropped and the
+    # requester sees a denial without a reason.
+    data = run(lambda ctx: ctx.output.validations.error("snapshot is missing"))
+    assert data == [{"allowed": False, "message": "Internal webhook error: snapshot is missing"}]