Repository navigation
fix(release): render Exempt line outside the last exception bullet - #463
Merged
Merged
Conversation
The Traceability exceptions template put the "Exempt (not attested)" line directly under the last "-" bullet. Markdown reads a paragraph line after a list item as part of that item, so the v3.5.0 release notes showed the Exempt line inside the last bullet. The template now has a blank line between the last bullet and the Exempt line, and the prose says to compose the block that way. A test collector checks the blank line and the stated rule, with a known-bad probe. The no-ask block (heading and Exempt line alone) has no bullet, so it needs no change.
Pre-release check 4 now says a local test failure is non-blocking when CI ran green at the release commit and the file passes an isolated re-run. It lists the load-caused failures seen in 3.5.0 that are not timeouts: the redact-secrets timing check, the eager-memory-refresh probe-pid ENOENT and the model-discovery live-probe asserts. It also names queue-append and shell-hooks as timing out under load. Post-release now notes that commits pushed straight to main with no PR show as untraced in the trace map and need a self-attested exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
/releasetraceability-exceptions template put theExempt (not attested): …line directly under the last exception bullet, with no blank line. Markdown read it as a lazy continuation of that bullet, so the v3.5.0 release notes showed the Exempt line inside the last bullet. This PR adds the blank line, states the rule in the template prose, and records two release-process lessons from the 3.5.0 test load and untraced commits.Changes
Bug Fixes
src/assets/commands/release.mds: one blank line between the lastuntracedorcoveragebullet and theExemptline, plus a prose rule that composed blocks keep that blank line. The no-ask block (heading and Exempt line, no bullets) is unchanged.tests/evidence/release-flow.test.ts: a test checks the blank line and the stated rule, with a known-bad probe. The closed-kinds test now skips blank lines.CHANGELOG.md: a### Fixedentry under[Unreleased].Documentation
.release/RELEASE-FLOW.md, pre-release check 4: a local test failure is non-blocking when CI ran green at the release commit and the file passes an isolated re-run. The check lists the load-caused failures seen in 3.5.0 that are not timeouts (redact-secrets timing, eager-memory-refresh probe-pid ENOENT, model-discovery live-probe asserts) and names queue-append and shell-hooks as timing out under load..release/RELEASE-FLOW.md, post-release: commits pushed straight to main with no PR show asuntracedand need a self-attested exception.Breaking Changes
None.
Testing
Test Coverage
npm run build:mds: 0 errors, 0 warnings.npm run build: exit 0.Testing Gaps
Related Issues
Closes #462
Reviewer Focus Areas
src/assets/commands/release.mds:166(blank line) and:171(prose rule).tests/evidence/release-flow.test.ts:364-373(lazy-continuation collector) and:398-407(test and known-bad probe)..release/RELEASE-FLOW.md:34: pre-release check 4 now makes a local failure non-blocking under the stated conditions. It changes the release gate, so review it as a process change.