Major dependency upgrade to PyMySQL v1.2.3 - #2274
Merged
Merged
Conversation
PyMySQL v1.2.0 was a breaking update which was avoided for some time. The defaults for ping() have changed such that reconnect is False, and reconnect=True is also deprecated with a user-visible warning. The defaults for SSL support on connect() have also changed: SSL mode is the default, and ssl_disabled must be set if SSL is not wanted. Changes * remove all reconnect parameters to ping() * remove reconnect=True pass for mycli's reconnect(), which may never have been useful anyway * add support for the ssl_disabled kwarg to PyMySQL's connect() * add a retry for PyMySQL's connect() on SSL failure with ssl_mode of "auto" * import "ssl" as "ssllib" in sqlexecute.py, since there is also a variable with the name "ssl" Each value of --ssl-mode on the client has been tested using a MySQL server both with and without SSL support. For the second case, a MySQL 8 server was run with --tls-version=''. On the client, the ability to connect under each combination was checked, along with consulting the output of /status. The behavior of the /connect command in various situations is more difficult to verify, but since we only removed the second of three passes to the reconnect behavior, we can be reasonably confident that the overall behavior is still good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PyMySQL v1.2.0 was a breaking update which was avoided for some time.
The defaults for
ping()have changed such thatreconnectisFalse, andreconnect=Trueis also deprecated with a user-visible warning.The defaults for SSL support on
connect()have also changed: SSL mode is the default, andssl_disabledmust be set if SSL is not wanted.Changes
reconnectparameters toping().reconnect=Truepass for mycli'sreconnect(), which may never have been useful anyway.ssl_disabledkwarg to PyMySQL'sconnect().connect()on SSL failure withssl_modeofauto.sslasssllibinsqlexecute.py, since there is also a variable with the namessl.Each value of
--ssl-modeon the client has been tested using a MySQL server both with and without SSL support. For the second case, a MySQL 8 server was run with--tls-version=''. On the client, the ability to connect under each combination was checked, along with consulting the output of/status.The behavior of the
/connectcommand in various situations is more difficult to verify, but since we only removed the second of three passes to the reconnect behavior, we can be reasonably confident that the overall behavior is still good.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).