Escape bytes parameters as strings, not as ARRAY of ints - #959
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
With inline parameters, ParamEscaper.escape_item checked for Sequence before bytes. Since bytes is a Sequence, a bytes value was escaped element by element (b"hi" became ARRAY(104,105)), and the bytes handling in escape_string, which decodes UTF-8 for older SQLAlchemy, was never reached. Route bytes to escape_string. Signed-off-by: Shubham Padkonde <shubhampadkonde12@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With inline parameters, ParamEscaper.escape_item checked for Sequence before bytes. Since bytes is a Sequence, a bytes value was escaped element by element (b"hi" became ARRAY(104,105)), and the bytes handling in escape_string, which decodes UTF-8 for older SQLAlchemy, was never reached. Route bytes to escape_string.
What type of PR is this?
Description
How is this tested?
Related Tickets & Documents