Repository navigation
Fix race condition in Client.scheduler_info - #9375
Open
TomAugspurger wants to merge 1 commit into
Open
TomAugspurger wants to merge 1 commit into
TomAugspurger wants to merge 1 commit into
Conversation
The periodic callback was setting `self._scheduler_identity` to an identity with 0 workers, so simply returning `self._scheduler_identity` from `Client.scheduler_info()` risks giving the wrong result. I think we need a fresh call.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 39 files - 1 39 suites - 1 14h 4m 55s ⏱️ - 17m 18s For more details on these failures, see this check. Results for commit 44c7592. ± Comparison against base commit dc182bd. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The periodic callback was setting
self._scheduler_identityto an identity with 0 workers, so simply returningself._scheduler_identityfromClient.scheduler_info()risks giving the wrong result. I think we need a fresh call.With this, the reproducer from #9374 doesn't error after 2 minutes / 133,000 calls (previously it errored after a couple dozen).
Closes #9374.