Skip to content

src/canonicalize.rs: apply clippy fixes with two places - #850

Merged
moritz-gross merged 1 commit into
daisy:mainfrom
hammera:main
Oct 7, 2026
Merged

moritz-gross merged 1 commit into
daisy:mainfrom
hammera:main

Conversation

@hammera

@hammera hammera commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Hi,

@moritz-gross, I applyed two simple clippy fixes after rustup update command build, because after my fork syncing to the upstream main branch, I get a notification failure e-mail with clippy fixes related.
So, I update my rust environment with rustup to the latest stable version, applyed clippy fixes with the proper cargo clippy related option, commit and push the changes.
After this commit, my fork the build pipeline is ran successfull.
If all checks result good too in upstream Github online workflows, and anybody reviewing this simple change, if need please merge this change to the upstream Mathcat repo main branch.
Now I use following Rust version my Debian 12 machine:
rustc 1.99.0 (b940084d7 2026-09-28)
Of course the cargo build, cargo test commands ran successful my local machine, I looked this commands results before pushing my fork main branch.

Attila

Signed-off-by: Attila Hammer <hammera@pickup.hu>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Linux library size: 0.58 MiB (0.00%)
Revision Release liblibmathcat.so
Base (7aa6b6f) 0.58 MiB (605,800 bytes)
PR (c008a39) 0.58 MiB (605,800 bytes)
Change 0 bytes (0.00%)

Built with default features, Rust 1.96.0, and Ubuntu 24.04. Workflow run.

@hammera

hammera commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

Very nice, all online checks are passed.
I am ready this PR. Because all checks are passed right, I think this PR are mergeable to the upstream level the main branch.
With fuzzingrelated workflow are why running estimated 122 minutes? Need processing this online workflow a large mathematical corpus, and the mathematical corpus processing require more time?

Attila

@moritz-gross

Copy link
Copy Markdown
Collaborator

Very nice, all online checks are passed. I am ready this PR. Because all checks are passed right, I think this PR are mergeable to the upstream level the main branch. With fuzzingrelated workflow are why running estimated 122 minutes? Need processing this online workflow a large mathematical corpus, and the mathematical corpus processing require more time?

Attila

you can click on the box where it says "all checks have passed". There it lists the runtime of each check. It is dominated by the fuzzing test that Neil has created a while ago, which takes 122 minutes. The other checks are all just a few minutes. Next time I talk to Neil, I will ask him about it, as I also don't exactly know the context around the fuzzing tests.

@moritz-gross

Copy link
Copy Markdown
Collaborator

ok, looks good. The clippy change is here for completeness of documentation: https://rust-lang.github.io/rust-clippy/rust-1.99.0/index.html#nonstandard_macro_braces

I wasn't aware that there is ambiguous syntax for macros like this, but I agree that we should then just fix it accordingly.

I'm surprised though that this then is the only place we need to clean up. I again checked the error description in your failed job and it only complains about these two lines.

@moritz-gross
moritz-gross merged commit afe0f25 into daisy:main Oct 7, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants