Skip to content

⚡ Bolt: memoize default github username discovery in init script #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
google-labs-jules wants to merge 1 commit into from
Closed

⚡ Bolt: memoize default github username discovery in init script #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import os
import re
import shutil
from functools import lru_cache
from pathlib import Path
from subprocess import CalledProcessError, TimeoutExpired, check_output

Expand Down Expand Up @@ -64,6 +65,7 @@ def _get_git_config(key: str) -> str:
return ""


@lru_cache(maxsize=1)
def _get_default_github() -> str:
# Try git config first
username = _get_git_config("github.user") or _get_git_config("user.name")
Expand Down
6 changes: 6 additions & 0 deletions tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,16 @@ def mock_check_output(args, **kwargs):


def test_get_default_github(monkeypatch):
# Clear lru_cache on _get_default_github before testing
init._get_default_github.cache_clear()

# Case 1: valid username in git config
monkeypatch.setattr(init, "_git_config_loaded", True)
monkeypatch.setattr(init, "_git_config_cache", {"github.user": "jane-doe"})
assert init._get_default_github() == "jane-doe"

# Case 2: invalid username in git config, fallback to remote URL (HTTPS format)
init._get_default_github.cache_clear()
monkeypatch.setattr(init, "_git_config_cache", {})

def mock_check_output(args, **kwargs):
Expand All @@ -84,6 +88,8 @@ def mock_check_output(args, **kwargs):
assert init._get_default_github() == "some-org"

# Case 3: invalid username in git config, fallback to remote URL (SSH format)
init._get_default_github.cache_clear()

def mock_check_output_ssh(args, **kwargs):
if "remote" in args and "get-url" in args:
return "git@github.com:ssh-user/some-repo.git\n"
Expand Down
Loading