Skip to content

feat: update to only use traits with no-default-features - #22

Merged
dhuseby merged 3 commits into
masterfrom
feat/traits-only
Nov 6, 2026
Merged

dhuseby merged 3 commits into
masterfrom
feat/traits-only

Conversation

@mikelodder7

Copy link
Copy Markdown
Contributor

This allows the various signature algorithms to be selected arbitrarily. If none are selected, only the traits are exported. This is useful when the cryptography will be provided externally.

I also did some minor performance improvements and fixed cargo doc which wasn't building before.

Signed-off-by: Mike Lodder <mikelodder@tectonic.xyz>
@mikelodder7
mikelodder7 requested a review from dhuseby October 15, 2026 23:08
# Conflicts:
#	Cargo.toml
#	src/views/threshold_meta.rs
blsful 4.2.0 drops crypto-bigint 0.5.5 (RUSTSEC-2026-0387). The multi-hash
dev-dependency was still on 3.0 next to the main dependency on 4, which stopped
the tests compiling with E0464.

@dhuseby dhuseby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added some comments. No changes requested. Ship it!

Comment thread benches/multikey_bench.rs Resolved
Comment thread src/serde/de.rs Resolved
Comment thread src/serde/mod.rs Resolved
Comment thread src/views/bcrypt.rs Resolved
Comment thread src/views/bls12381.rs Resolved
Comment thread src/views/bls12381_g1_mayo1.rs Resolved
Comment thread src/views/x25519_mceliece348864.rs Resolved
Comment thread Cargo.toml Resolved
@dhuseby
dhuseby merged commit 50b9dcb into master Nov 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants