Skip to content

Marks on hidden files stay counted across a reload - #63

Merged
crustovsky merged 1 commit into
open-withfrom
hidden-marks-count
Nov 9, 2026
Merged

crustovsky merged 1 commit into
open-withfrom
hidden-marks-count

Conversation

@crustovsky

Copy link
Copy Markdown
Owner

Fixes #62. Stacked on #61; now the tip of the chain (#58, #59, #60, #61).

Found in the pre-release pass: a marked dotfile, hidden afterwards, was left out of the count after a reload while a job still took it. One line in ListModel::applyMarks, one case in test_tab.

🤖 Generated with Claude Code

A marked dotfile that was then hidden (Ctrl+F7) dropped out of the
count at the next reload while staying marked: the status line said
"1 selected", F8 asked about "1 items" and two files went, because
the jobs take every marked entry. With only hidden entries marked
the count fell to zero and F8 acted on the cursor item instead.

applyMarks counts every mark it restores, as invert, mark all and
clear do since #55. The prompt of a job then reads "2 items (1 not
shown)", which is what happens.

Fixes #62

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@crustovsky
crustovsky merged commit 4780a9d into open-with Nov 9, 2026
2 checks passed
@crustovsky
crustovsky deleted the hidden-marks-count branch November 9, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant