Conversation
danmar
changed the title
danmar
commented
Oct 2, 2026
danmar
commented
Oct 2, 2026
| } | ||
| } | ||
|
|
||
| std::vector<std::string> PathMatch::unmatched() const { |
Collaborator
Author
There was a problem hiding this comment.
This is an AI review take it with a grain of salt. Please feel free to reject it by clicking on Resolve button
Header excludes can never be "used", because Path::acceptFile() filters out headers before ignored.match() is called. So -iinc/h.h src or -i*.h src now prints:
cppcheck: filename exclusion does not apply to header (.h and .hpp) files.
cppcheck: Please use --suppress for ignoring results from the header files.
cppcheck: error: unused ignore/exclude path 'inc/h.h'. To hide warnings in certain files use suppressions instead.
and exits with code 1. Before, this was only an informational message. If failing is intended for headers, the first two lines could probably be merged into the error, or dropped, so the same thing isn't said twice. If it isn't intended, header patterns could be left out of the unused check.
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.