Conversation
olabetskyi
previously approved these changes
Sep 24, 2026
wjakobsson
reviewed
Sep 24, 2026
| <long-long>8</long-long> | ||
| <float>4</float> | ||
| <double>8</double> | ||
| <long-double>8</long-double> |
Collaborator
There was a problem hiding this comment.
For Apple ARM64, long double being 8 bytes is correct: https://developer.apple.com/documentation/xcode/writing-arm64-code-for-apple-platforms.
However, the generic AAPCS64 specifies long double as quad precision, 16 bytes: https://github.com/ARM-software/abi-aa/blob/main/aapcs64/aapcs64.rst
Is this file intended to model Apple or generic AAPCS64? If the latter maybe it should be updated form 8 to 16?
Collaborator
Author
There was a problem hiding this comment.
Good catch I update to 16 to match common linux arm64 platforms.
There will be users that will not be able to use our arm64 platform files, they will have to configure their own arm64.xml files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.