test: add acceptance coverage for the ITS pipeline - #3591
dheerajodha wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe acceptance framework now runs repository pipeline definitions in kind and checks PipelineRun outcomes and results. New scenarios cover image validation with signed and missing images. Related documentation and a task-test ConfigMap name were updated. ChangesITS pipeline acceptance
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Other Sequence Diagram(s)sequenceDiagram
participant GodogSteps
participant kindCluster
participant KubernetesAPI
GodogSteps->>kindCluster: RunPipeline with pipeline parameters
kindCluster->>KubernetesAPI: Create PipelineRun
GodogSteps->>kindCluster: AwaitUntilPipelineIsDone
kindCluster->>KubernetesAPI: Poll PipelineRun
KubernetesAPI-->>kindCluster: Completion status and results
kindCluster-->>GodogSteps: PipelineInfo
Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change adds pipeline acceptance checks without an identified merge-blocking defect. Complete the normal acceptance checks; the reported local run did not finish. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 6 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
|
Risk Assessment: moderate (2/5) DetailsAll changes are test/acceptance code with no production paths touched, but the XL size, new Cluster-interface method additions, and rename of a shared test fixture in a stable directory each contribute incremental integration risk, landing the PR at moderate. |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
requires-manual-review
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
🤖 Finished Review · ❌ Failure (ensuring provider "vertex-ai": provider create "vertex-ai" failed: exit status 1 (output: Error: × code: 'Client specified an invalid argument', message: "provider │ credentials are not declared by pr…) · Started 1:12 PM UTC · Completed 1:12 PM UTC Commit: Effort: high |
This branch has not been deployed
1 participant
What:
Add acceptance coverage for the ITS pipeline in a kind cluster using the pipeline definition and task bundles from the checkout. Scenarios cover a signed image passing validation, strict validation failure, and non-strict validation failure. Each checks both PipelineRun completion and the pipeline's
TEST_OUTPUTresult.The Kubernetes test helpers now launch and await PipelineRuns with a bounded timeout. Rename the existing keyless ConfigMap fixture so its dummy service URLs do not affect concurrent pipeline tests.
Why:
Catch pipeline wiring and validation regressions in the CLI repository before merge, complementing the separate e2e coverage. The scenarios run in the existing acceptance suite and PR Checks workflow, which already includes pipeline-only changes.
Validation:
CGO_ENABLED=0 go test ./kubernetes/...in the acceptance module: passed (package compilation)../kubernetes/...: passed with zero issues.git diff --check: passed.@its-pipelineacceptance run reached PipelineRuns but could not complete locally: the Podman VM had insufficient memory for verify pods, and the existing test-image builder packaged a macOS binary into the Linux image (Exec format error). The blocked run was stopped and its test containers removed. End-to-end validation is still pending.Tickets:
EC-1948