Repository navigation
Update action trust store to reject compromised eMudhra chains - #6
Merged
Merged
Conversation
Build the checked-in Dockerfile with maintained Ruby and a minimum Debian CA security update, rather than pulling the stale prebuilt action image. Add offline trust regression checks and CI, preserving package glob expansion. Amp-Thread-ID: https://ampcode.com/threads/T-6032f029-f131-44a8-84a8-b880691cc1b4 Co-authored-by: Amp <amp@ampcode.com>
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
Keep image-build and CLI-startup checks, and remove the certificate fixtures and their documentation references.
buildsworth-bk-app
Bot
dismissed
their stale review
October 21, 2026 05:26
Superseded by a newer Buildsworth review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The action uses an old Docker Hub image with outdated trusted certificates. Updating certificates on the GitHub runner does not fix the certificates inside that image. The action needs an updated certificate store to reject the compromised eMudhra certificate chains.
What
Dockerfileinstead of pulling the old0.0.2image.ruby:3.4-slim-bookworm. This follows Ruby 3.4 patch updates, not new Ruby major or minor versions.ca-certificatespackage version20250419~deb12u2or newer. This update removes trust inemSign ECC Root CA - G3andAAA Certificate Services. Use Debian's certificate store without a custom blocklist, and keep TLS checks enabled.package_cloud0.3.15 and remove the unused Bullseye build files.dist/*.tar.gz, and return the CLI's exit code when an upload fails.Each workflow run now builds the image, so startup takes longer while Docker pulls the base image and installs packages and gems. Users must update to a commit or release containing this fix. Older pinned commits and tags will not receive the fix.
The local Docker build and CLI checks passed, and the current GitHub Actions image check passed. No packages were uploaded. This PR does not merge the change, publish a Docker image, or create or move release tags.