Repository navigation
P3 - #89
Merged
Merged
P3#89
Conversation
The all wrap network calls, which themselves will be async. wasi:keyvalue is entierly sync, so wit_bindgen::block_on is used. Signed-off-by: Scott Andrews <scott@andrews.me>
Signed-off-by: Scott Andrews <scott@andrews.me>
Signed-off-by: Scott Andrews <scott@andrews.me>
- wasi:http@0.2 -> 0.3 - wasi:keyvalue -> wasmcloud:keyvalue - add expire, expireat, hexpire, hexpireat operations Dropping wasi:keyvalue was required as the component model currently does not fully support calling a async method from a sync method. This restriction will be reverted once the component model restriction is resolved, or wasi:keyvalue's api becomes async. Until then, wasmcloud has an interface that is substantially similar and already async. Signed-off-by: Scott Andrews <scott@andrews.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All methods touching a network socket are now async, and using the wasi p3 interfaces.
Dropping
wasi:keyvaluewas required as the component model currently does not fully support calling a async method from a sync method.wasi:keyvaluesupport will be restored once the component model restriction is resolved, orwasi:keyvalue's api becomes async (WebAssembly/wasi-keyvalue#68). Until then,wasmcloud:keyvaluehas an interface that is substantially similar and already async.Added addition commands to fully implement
wasmcloud:keyvalue:expireexpireathexpirehexpireatThe cli component is now built with
wasm32-unknown-unknown, droppingwasm32-wasip2.