Conversation
EhabY
force-pushed
the
feat/workspace-update-parameters
branch
from
September 24, 2026 19:12
8c9fb00 to
509f683
Compare
EhabY
force-pushed
the
feat/workspace-update-parameters
branch
2 times, most recently
from
September 24, 2026 19:33
3ef08aa to
cab6547
Compare
Updating a workspace whose template uses dynamic parameters now works like the dashboard: the new template version is evaluated with the current values, and a form opens only when they fail. The form replaces collectUpdateParameters for dynamic templates, so the existing updateWorkspace flow still performs the build. Also runs the lint and format tools through Node so pnpm lint and pnpm format work on Windows.
EhabY
force-pushed
the
feat/workspace-update-parameters
branch
from
September 24, 2026 19:50
cab6547 to
f89dcac
Compare
Adds ValidationMessage to @repo/ui with VS Code's info, warning, and error input validation styles and stories for every theme, and gives invalid text controls and selects the validation border. The workspace update form uses it for parameter diagnostics.
EhabY
force-pushed
the
feat/workspace-update-parameters
branch
from
September 24, 2026 19:58
f89dcac to
ea26cd1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updating a workspace whose template uses dynamic parameters now works like the dashboard. The extension evaluates the new template version with the workspace's current values. If they still pass, the update goes ahead with no prompt. If not, an editor-tab form asks for the missing or invalid values.
collectUpdateParametersfor dynamic templates, so the existingupdateWorkspaceflow still does the build (one-build stop and start, older-server fallbacks, telemetry, build logs).order, and typing is debounced 500ms@repo/uicontrols and VS Code Settings-editor styling. It evaluates through typed IPC requests with React Query and keeps typed values when the tab is hidden.template_use_classic_parameter_flowkeep the classic prompts.pnpm lintandpnpm formaton Windows: the.binshims are.cmdfiles thatspawnSynccan't run without a shell, so the scripts now run each tool's JS entry through Node.The second commit adds
ValidationMessageto@repo/ui. It matches VS Code's input box validation message (info, warning, and error, using theinputValidationtheme colors), has stories for every theme, and gives invalid text controls and selects VS Code's validation border. The form uses it for parameter diagnostics.Addresses #972.
Size
About 1.6k added lines against
main:ValidationMessage)ValidationMessagecases)ValidationMessagestories in light, dark, and both high-contrast themes)Validation
pnpm lint,pnpm typecheck,pnpm format:check,pnpm buildpnpm test: 190 files, 2,780 tests passed