Enforce IP block after routing so SEF password-reset URLs stay reachable - #230
Merged
Merged
Conversation
With search-engine-friendly URLs, option/view are empty during onAfterInitialise, so the password recovery exemption never matched. Move block enforcement to onAfterRoute. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012WRXzvnnYWqSNzhQUDLdWB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With search-engine-friendly URLs (Joomla's default), a blocked user can't reach the password-reset page.
isPasswordRecoveryRequest()ran inonAfterInitialise, before Joomla routed the request, sooption/viewwere still empty for URLs like/index.php/component/users/reset. Joomla also redirects the non-SEF reset link to the SEF one. The same applied to the unblock-token and login-only checks, which read the same input.Change
onAfterRoute; block enforcement (allow-list, active-block lookup, unblock/password-recovery/login-only exemptions, block response) moved there.onAfterInitialisekeeps setup and the purge of old entries.fixtures/request.php) dispatchesonAfterRouteafteronAfterInitialise(--no-routeskips it); new testtestBlockIsEnforcedOnlyAfterRouting.Notes
/index.php/component/users/resetand/remindas a blocked IP should load, other URLs stay blocked.🤖 Generated with Claude Code
https://claude.ai/code/session_012WRXzvnnYWqSNzhQUDLdWB
Generated by Claude Code