Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qy73oCK2ZQyvqMP9DKoFkN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DatabaseHelperTest::testUsernameStatisticsfailed intermittently in CI, withfirst_attemptoff by one second (21:11:29expected,21:11:28actual).Cause
The failed-login timestamps are generated from
time()when the rows are inserted. The assertions then compared them against a secondtime()reading taken at assertion time. If a second boundary passed between the two reads, the values differed by one second.Fix
The test now records
time()before and after the inserts. It asserts that the storedfirst_attemptandlast_attemptfall within that window, shifted by 30 and 10 minutes. This holds no matter when the clock ticks over.Only the test changes; there is no production code change.
Testing
I couldn't run PHPUnit in my environment, only a PHP syntax check (
php -l). CI will run the full suite.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qy73oCK2ZQyvqMP9DKoFkN
Generated by Claude Code