fix: handle missing git in GitHub Actions CI adapter - #796
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses a
FileNotFoundErrorthat occurred when thecodecov-cliwas run in a GitHub Actions environment wheregitwas not installed or not in the system'sPATH.The
GithubActionsCIAdapter._get_commit_sha()method attempts to determine the parent commit SHA usinggit rev-parse HEAD^@when a pull request number is detected. Previously, thissubprocess.runcall was not wrapped in any error handling. Ifgitwas not found, it would lead to an unhandledFileNotFoundErrorand crash the CLI.The fix involves wrapping the
subprocess.runcall in atry/except OSErrorblock. If anOSError(which includesFileNotFoundError) occurs, the CLI will now gracefully fall back to using theGITHUB_SHAenvironment variable, which is already the intended fallback for other scenarios where the git command might not yield the expected result. This prevents the CLI from crashing and ensures it can still report coverage in environments withoutgit.Fixes CLI-HB
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.