Skip to content

Add Python OneAgent code-module to Dynatrace hook - #1231

Open
arthfl wants to merge 9 commits into
cloudfoundry:masterfrom
arthfl:master
Open

arthfl wants to merge 9 commits into
cloudfoundry:masterfrom
arthfl:master

Conversation

@arthfl

@arthfl arthfl commented Oct 6, 2026

Copy link
Copy Markdown
Contributor
  • A short explanation of the proposed change:
    Adds python code-module to Dynatrace hook
    Bumps libbuildpack-dynatrace to v1.10.0

  • An explanation of the use cases your change solves
    Enables users of the Dynatrace integration in the python-buildpack to also utilize the Python code-module of the Dynatrace OneAgent.

  • I have viewed signed and have submitted the Contributor License Agreement

  • I have made this pull request to the master branch

  • I have added an integration test

@ivanovac

ivanovac commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@arthfl
go.sum is inconsistent: Please, run go mod tidy and go mod vendor and commit the cleaned go.sum

Testing: No test file is added or modified. Also, the existing src/python/integration/dynatrace_test.go cannot verify this change: the mock server (fixtures/util/dynatrace/main.go) ignores the include= query parameters entirely and serves the installer regardless of requested technologies. So the new python module is effectively untested — nothing asserts that include=python is actually sent.
Suggestion: add a unit test on getDownloadURL asserting the python include is present, or extend the mock to record/assert the include params. (A pure buildpack-side integration test is hard here precisely because of the mock's design.)

@ivanovac ivanovac left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check the comments above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants