Fix stale Access application path parameter tests - #2748
Open
FranciscoMaxwell wants to merge 1 commit into
Open
FranciscoMaxwell wants to merge 1 commit into
FranciscoMaxwell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes being requested
This updates stale Access application path-parameter tests so they match the current account/zone routing behavior.
account_idvalidation assertion.account_idcall to raiseValueError.Additional context & links
Related to #2705 and #2747.
Testing
python -m compileall -q tests\api_resources\zero_trust\access\test_applications.pygit diff --checkI could not run the focused pytest command locally because
pytestis not installed in my environment. The touched tests are also currently marked skipped in the generated suite.