Repository navigation
Preserve declared scalar types when reading SQLite values - #89
Merged
Merged
Conversation
xrotwang
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Database.read()applies the write converter a second time, returning integers for boolean columns and floats for decimal columns. For example:Before:
[{"flag": 1}, {"flag": 0}]. After:[{"flag": true}, {"flag": false}].Use the existing
DBType.readconverter for scalar reads. Add type-sensitive boolean/decimal regressions, including nulls; equality alone misses this becauseTrue == 1. Decimal storage keeps SQLite's existing REAL precision.Validation: full suites pass on Python 3.12 (841 passed, 16 expected failures) and 3.9 (844 passed, 13 expected failures), with 100% configured coverage. Changed source/test Flake8 passes. Shipped Frictionless CSV data and exactly representable decimal values exercise CSV/direct writes, renamed columns and memory/file SQLite: all 12 typed pipelines are repaired, while eight complete non-boolean/table controls and raw SQLite row hashes remain exact. A fresh installed wheel reproduces the results. The Frictionless fixture's unrelated foreign-key metadata is excluded explicitly; its CSV bytes are unchanged.