Repository navigation
Preserve composite foreign-key column correspondence in SQLite - #85
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TableSpec.from_table_metadatasorts the referencing and referenced columns independently. This changes a composite foreign key's meaning when the two sets of names sort differently. A dataset can pass CSVW validation and then failcsvw2sqlitewithFOREIGN KEY constraint failed.For example,
child(left, right) -> parent(zeta, alpha)becomeschild(left, right) -> parent(alpha, zeta). Keep both column lists in their declared order.The two regression cases insert valid rows, reject invalid pairs, and check cascading deletes with both declaration orders. Both fail before this change. The full suite passes on Python 3.12 (827 passed, 16 expected failures) and 3.9 (830 passed, 13 expected failures); Flake8 passes for the changed files.
CSVW validation, CLI SQLite export and SQL joins were also checked using recorded lexical data. Eight previously failing export configurations now work; eight working configurations retain identical rows and joins.