Repository navigation
feat: complete --output values in the shell - #616
Merged
Merged
Conversation
fulviodenza
approved these changes
Nov 9, 2026
fulviodenza
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PRs opened, I'm going to release these in the next tag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the suggestion on #608. Now that
--outputonly acceptsjson,humanandcustom, the shell can complete those values instead of suggesting file names.It's one
RegisterFlagCompletionFunccall on the root command usingcobra.FixedCompletionswithcommon.OutputFormats, so the list stays in one place. Since--outputis a persistent flag, every subcommand gets it too.I also tried the generated bash script, and
civo kubernetes ls -o c<TAB>completes tocustom. The other shells go through the same__completecommand, so they pick it up as well.Tests:
TestOutputFlagCompletesFormatsincmd/root_test.gochecks the completion on the root command and on a subcommand, and fails if the registration is removed.go test ./...and golangci-lint pass.