Repository navigation
docs: fix browser-checks/examples (DOC-150) - #656
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
The old example's 'contrast check' only compared two colors. Checkly runtimes ship @axe-core/playwright; tested with 4.11.1: a clean page passes, a page with contrast, label and alt-text issues fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Follow-up from review (F254): the accessibility example now uses |
hlenke
marked this pull request as ready for review
October 28, 2026 19:08
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes a broken example from the browser check examples page and adds a note about imports.
What was wrong
page.evaluatehangs until the 30 s test timeout: thePerformanceObserveris created after the page has loaded, so its callback never fires and the promise never resolves. It also waits on FID, which needs a real user click.testandexpect, so copying one into a check givestest is not defined.What changed
@playwright/testimport.Not changed (noted on the ticket)
The rest of the page is generic sample code. The accessibility example's "contrast check" only compares two colors, and using
@axe-core/playwrightwould be better. Rewriting the page is a bigger editorial job, so I left it for a follow-up.vale and
npm run check:linksare clean.Linear: DOC-150
🤖 Generated with Claude Code