Repository navigation
feat(helm): add useLegacyGRPCEndpoints to select client endpoints - #3830
Conversation
Add the top-level useLegacyGRPCEndpoints value, with the same name and behavior as in the chainloop-ee chart. It selects the endpoints that the clients use: the control plane connection to the CAS and the CLI configuration in the release notes. The default is true, so the clients keep the deprecated gRPC-only endpoints (ingressAPI, serviceAPI) and the rendered defaults do not change. Only an explicit false selects the shared endpoints (ingress, service), because helm upgrade --reuse-values from an older chart leaves the key unset. The chart keeps the deprecated endpoints in both modes. Document the deprecation of the gRPC-only endpoints and the steps to move to the shared endpoints. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Chainloop-Trace-Sessions: c75d9b0a-d1bf-4dd9-b1dc-cc40db862e79
PR validation — ✅ 3 passing
AI Session Checks — 🟢 89% ·
|
| Avg score | Sessions | Failing policies | Attribution | Files | Lines | Total Duration |
|---|---|---|---|---|---|---|
| 🟢 89% | 1 | 74% AI / 26% Human | 7 | +382 / -73 | 41m33s |
🟢 89% — 74% AI — ⚠️ 1 policies failing
-
Nov 18, 2026 11:46 UTC · 41m33s · $14.45 · 412 in / 172.7k out · claude-code 2.1.327 (claude-opus-5-5)
Change Summary
-
- Adds
useLegacyGRPCEndpointswith legacy defaults and explicit opt-in to shared endpoints. - Updates the control-plane CAS address and CLI setup hints to follow endpoint selection.
- Documents legacy-entry deprecation and migration, with nine chart regression cases.
- Bumps the chart patch version from 1.489.0 to 1.489.1.
- Adds
AI Session Overall Score
-
🟢 89% — Focused, compatible change with passing chart checks; deployment behavior still lacks explicit user confirmation.
AI Session Analysis Breakdown
-
🟢 95% · scope-discipline
-
🟢 Deferred the unrelated node-port formatting defect and server-listener flag instead of bundling them into the endpoint-selector change. · High Impact
🟢 94% · context-and-planning
-
No notes.
🟢 93% · alignment
-
No notes.
🟢 92% · solution-quality
-
🟢 Centralized explicit-false selection preserves upgrade compatibility and consistently switches endpoint derivation rather than rewriting rendered output. · High Impact
🟢 86% · user-trust-signal
-
No notes.
🟡 79% · verification
-
🟢 Nine real render regressions passed after expected initial failures, and normalized default renders stayed unchanged. · High Impact
🟠 The user remained active after delivery but never explicitly confirmed that the selected endpoints worked. · Medium Severity
💡 Before merging, exercise the selected endpoints in your deployment and explicitly record whether the CLI and CAS connection work.
-
File Attribution
██████████████░░░░░░74% AI / 26% HumanStatus Attribution File Lines modified ai deployment/chainloop/README.md+146 / -66 created ai deployment/chainloop/endpoints_test.go+187 / -0 modified ai deployment/chainloop/templates/NOTES.txt+18 / -2 modified ai deployment/chainloop/templates/_helpers.tpl+18 / -0 modified ai deployment/chainloop/values.yaml+8 / -4 modified ai deployment/chainloop/templates/controlplane/configmap.yaml+4 / -0 modified ai deployment/chainloop/Chart.yaml+1 / -1
Policies (4, 1 failing)
Status Policy Material Messages ✅ Passed ai-config-ai-agents-allowedai-coding-session-c75d9b- ✅ Passed ai-config-no-dangerous-commandsai-coding-session-c75d9b- ⚠️ Failedai-config-no-secretsai-coding-session-c75d9b- Secret (generic-api-key) detected in session content [turn=230, source=tool_result, line=10]: < checksum/secret-config: [CHAINLOOP_TRACE_REDACTED:generic-api-key]
- Secret (generic-api-key) detected in session content [turn=230, source=tool_result, line=12]: > checksum/secret-config: [CHAINLOOP_TRACE_REDACTED:generic-api-key]
- Secret (generic-api-key) detected in session content [turn=849, source=tool_result, line=253]: |
⚠️ Failed |ai-config-no-secrets| [ai-coding-session-c75d9b](https://app.chainloop.dev/u/chainloop/projects/chainloop/versi...
✅ Passed ai-config-mcp-servers-allowedai-coding-session-c75d9b- -
Security Checks — ✅ 6 passing
✅ secret-scan
| Status | Policy | Messages |
|---|---|---|
| ✅ Passed | secrets-detection |
- |
✅ sast-scan
| Status | Policy | Messages |
|---|---|---|
| ✅ Passed | owasp-top10-2025 |
- |
| ✅ Passed | sast |
- |
| ✅ Passed | cwe-top25 |
- |
| ✅ Passed | cwe-top26-40-cusp |
- |
✅ iac-scan
| Status | Policy | Messages |
|---|---|---|
| ✅ Passed | iac-misconfiguration |
- |
Scans not applied (2)
| Scan | Reason |
|---|---|
vulnerability-scan |
no manifest/lockfile changed |
github-actions-scan |
no workflow files changed |
Powered by Chainloop and Chainloop Trace
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Add an Exposed endpoints section and an Upgrading section with the migration to the shared control plane and CAS endpoints, in the same structure as the chainloop-ee chart README. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Chainloop-Trace-Sessions: c75d9b0a-d1bf-4dd9-b1dc-cc40db862e79
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
Say that the deprecated Ingresses need ingressAPI.enabled, cover Service-based exposure and plain HTTP in the migration steps, and name the install notes (NOTES.txt) instead of the release notes. Assisted-by: Claude Code Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Chainloop-Trace-Sessions: c75d9b0a-d1bf-4dd9-b1dc-cc40db862e79
Add the top-level
useLegacyGRPCEndpointsvalue to the open source chart, with the same name and behavior as in thechainloop-eechart (chainloop-dev/platform#7278).cas_server.grpc.addr) and thechainloop config savecommand in the install notes (NOTES.txt).true. The clients keep the deprecated gRPC-only endpoints (ingressAPI,serviceAPI), and the rendered defaults do not change.falseto use the shared endpoints (ingress,service), which serve HTTP and native gRPC on one hostname. Only an explicitfalseselects them, becausehelm upgrade --reuse-valuesfrom an older chart leaves the key unset. A later release changes the default tofalse.ingressAPI.enabledandserviceAPI.typeparameters are marked as deprecated.Rendered diffs (base 1.489.0 vs head 1.489.1)
All renders use
development=true. The diffs ignore the chart version labels, the dev-mode secrets that are random on every render, and the checksums that follow from them. NOTES.txt is rendered too. Scenarios: no Ingress (ClusterIP), all four Ingresses with TLS, NodePort Services, LoadBalancer Services.Default values, and
useLegacyGRPCEndpoints=true: no diff in any scenario.useLegacyGRPCEndpoints=false, all four Ingresses with TLS:useLegacyGRPCEndpoints=false, no Ingress:With LoadBalancer and NodePort Services, the install notes read the shared Services (
t-chainloop-controlplane,t-chainloop-cas) and their node ports.AI disclosure: this change was produced with assistance from Claude Code.
closes https://linear.app/chainloop/issue/PFM-7958