Skip to content

feat(helm): add useLegacyGRPCEndpoints to select client endpoints - #3830

Merged
migmartri merged 3 commits into
chainloop-dev:mainfrom
migmartri:feat/helm-use-legacy-grpc-endpoints
Nov 18, 2026
Merged

migmartri merged 3 commits into
chainloop-dev:mainfrom
migmartri:feat/helm-use-legacy-grpc-endpoints

Conversation

@migmartri

@migmartri migmartri commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Add the top-level useLegacyGRPCEndpoints value to the open source chart, with the same name and behavior as in the chainloop-ee chart (chainloop-dev/platform#7278).

  • The value selects the endpoints that the clients use: the control plane connection to the CAS (cas_server.grpc.addr) and the chainloop config save command in the install notes (NOTES.txt).
  • The default is true. The clients keep the deprecated gRPC-only endpoints (ingressAPI, serviceAPI), and the rendered defaults do not change.
  • Set it to false to use the shared endpoints (ingress, service), which serve HTTP and native gRPC on one hostname. Only an explicit false selects them, because helm upgrade --reuse-values from an older chart leaves the key unset. A later release changes the default to false.
  • The chart keeps the deprecated endpoints in both modes, so existing CLIs continue to work.
  • The README documents the deprecation of the gRPC-only endpoints and the steps to move to the shared endpoints. The ingressAPI.enabled and serviceAPI.type parameters are marked as deprecated.
Rendered diffs (base 1.489.0 vs head 1.489.1)

All renders use development=true. The diffs ignore the chart version labels, the dev-mode secrets that are random on every render, and the checksums that follow from them. NOTES.txt is rendered too. Scenarios: no Ingress (ClusterIP), all four Ingresses with TLS, NodePort Services, LoadBalancer Services.

Default values, and useLegacyGRPCEndpoints=true: no diff in any scenario.

useLegacyGRPCEndpoints=false, all four Ingresses with TLS:

-        addr: t-chainloop-cas-api:80
+        addr: t-chainloop-cas:80
...
-      --control-plane cp-api.ex.com:443 \
-      --artifact-cas cas-api.ex.com:443
+      --control-plane cp.ex.com:443 \
+      --artifact-cas cas.ex.com:443

useLegacyGRPCEndpoints=false, no Ingress:

-        addr: t-chainloop-cas-api:80
+        addr: t-chainloop-cas:80
...
-       kubectl port-forward --namespace default svc/t-chainloop-controlplane-api 9000:80 &
+       kubectl port-forward --namespace default svc/t-chainloop-controlplane 9000:80 &
...
-       kubectl port-forward --namespace default svc/t-chainloop-cas-api 9001:80 &
+       kubectl port-forward --namespace default svc/t-chainloop-cas 9001:80 &

With LoadBalancer and NodePort Services, the install notes read the shared Services (t-chainloop-controlplane, t-chainloop-cas) and their node ports.

AI disclosure: this change was produced with assistance from Claude Code.

closes https://linear.app/chainloop/issue/PFM-7958

View guided diff

Add the top-level useLegacyGRPCEndpoints value, with the same name and
behavior as in the chainloop-ee chart. It selects the endpoints that the
clients use: the control plane connection to the CAS and the CLI
configuration in the release notes.

The default is true, so the clients keep the deprecated gRPC-only
endpoints (ingressAPI, serviceAPI) and the rendered defaults do not
change. Only an explicit false selects the shared endpoints (ingress,
service), because helm upgrade --reuse-values from an older chart leaves
the key unset. The chart keeps the deprecated endpoints in both modes.

Document the deprecation of the gRPC-only endpoints and the steps to
move to the shared endpoints.

Assisted-by: Claude Code
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

Chainloop-Trace-Sessions: c75d9b0a-d1bf-4dd9-b1dc-cc40db862e79
@chainloop-platform

chainloop-platform Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

PR validation — ✅ 3 passing

Status Policy Material Messages
✅ Passed pr-min-approvals pr-info -
✅ Passed pr-description-required pr-info -
✅ Passed pr-user-story-linked pr-info -

View attestation ↗

AI Session Checks — 🟢 89% · ⚠️ 1 failing

Avg score Sessions Failing policies Attribution Files Lines Total Duration
🟢 89% 1 ⚠️ 1 74% AI / 26% Human 7 +382 / -73 41m33s

🟢 89% — 74% AI — ⚠️ 1 policies failing

Nov 18, 2026 11:46 UTC · 41m33s · $14.45 · 412 in / 172.7k out · claude-code 2.1.327 (claude-opus-5-5)

View session details ↗

Change Summary

  • Adds useLegacyGRPCEndpoints with legacy defaults and explicit opt-in to shared endpoints.
  • Updates the control-plane CAS address and CLI setup hints to follow endpoint selection.
  • Documents legacy-entry deprecation and migration, with nine chart regression cases.
  • Bumps the chart patch version from 1.489.0 to 1.489.1.

AI Session Overall Score

🟢 89% — Focused, compatible change with passing chart checks; deployment behavior still lacks explicit user confirmation.

AI Session Analysis Breakdown

🟢 95% · scope-discipline

🟢 Deferred the unrelated node-port formatting defect and server-listener flag instead of bundling them into the endpoint-selector change. · High Impact

🟢 94% · context-and-planning

No notes.

🟢 93% · alignment

No notes.

🟢 92% · solution-quality

🟢 Centralized explicit-false selection preserves upgrade compatibility and consistently switches endpoint derivation rather than rewriting rendered output. · High Impact

🟢 86% · user-trust-signal

No notes.

🟡 79% · verification

🟢 Nine real render regressions passed after expected initial failures, and normalized default renders stayed unchanged. · High Impact

🟠 The user remained active after delivery but never explicitly confirmed that the selected endpoints worked. · Medium Severity

💡 Before merging, exercise the selected endpoints in your deployment and explicitly record whether the CLI and CAS connection work.


File Attribution

██████████████░░░░░░ 74% AI / 26% Human

Status Attribution File Lines
modified ai deployment/chainloop/README.md +146 / -66
created ai deployment/chainloop/endpoints_test.go +187 / -0
modified ai deployment/chainloop/templates/NOTES.txt +18 / -2
modified ai deployment/chainloop/templates/_helpers.tpl +18 / -0
modified ai deployment/chainloop/values.yaml +8 / -4
modified ai deployment/chainloop/templates/controlplane/configmap.yaml +4 / -0
modified ai deployment/chainloop/Chart.yaml +1 / -1

Policies (4, 1 failing)

Status Policy Material Messages
✅ Passed ai-config-ai-agents-allowed ai-coding-session-c75d9b -
✅ Passed ai-config-no-dangerous-commands ai-coding-session-c75d9b -
⚠️ Failed ai-config-no-secrets ai-coding-session-c75d9b
  • Secret (generic-api-key) detected in session content [turn=230, source=tool_result, line=10]: < checksum/secret-config: [CHAINLOOP_TRACE_REDACTED:generic-api-key]
  • Secret (generic-api-key) detected in session content [turn=230, source=tool_result, line=12]: > checksum/secret-config: [CHAINLOOP_TRACE_REDACTED:generic-api-key]
  • Secret (generic-api-key) detected in session content [turn=849, source=tool_result, line=253]: | ⚠️ Failed | ai-config-no-secrets | [ai-coding-session-c75d9b](https://app.chainloop.dev/u/chainloop/projects/chainloop/versi...
✅ Passed ai-config-mcp-servers-allowed ai-coding-session-c75d9b -

Security Checks — ✅ 6 passing

✅ secret-scan

Status Policy Messages
✅ Passed secrets-detection -

✅ sast-scan

Status Policy Messages
✅ Passed owasp-top10-2025 -
✅ Passed sast -
✅ Passed cwe-top25 -
✅ Passed cwe-top26-40-cusp -

✅ iac-scan

Status Policy Messages
✅ Passed iac-misconfiguration -
Scans not applied (2)
Scan Reason
vulnerability-scan no manifest/lockfile changed
github-actions-scan no workflow files changed

View attestation ↗


Powered by Chainloop and Chainloop Trace

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread deployment/chainloop/README.md Resolved
Comment thread deployment/chainloop/README.md Resolved
Add an Exposed endpoints section and an Upgrading section with the
migration to the shared control plane and CAS endpoints, in the same
structure as the chainloop-ee chart README.

Assisted-by: Claude Code
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

Chainloop-Trace-Sessions: c75d9b0a-d1bf-4dd9-b1dc-cc40db862e79
@migmartri
migmartri marked this pull request as ready for review November 18, 2026 12:20
@migmartri
migmartri requested review from a team, javirln and jiparis November 18, 2026 12:21

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 1 file (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread deployment/chainloop/README.md Resolved
Comment thread deployment/chainloop/README.md Resolved
Say that the deprecated Ingresses need ingressAPI.enabled, cover
Service-based exposure and plain HTTP in the migration steps, and name
the install notes (NOTES.txt) instead of the release notes.

Assisted-by: Claude Code
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>

Chainloop-Trace-Sessions: c75d9b0a-d1bf-4dd9-b1dc-cc40db862e79
@migmartri
migmartri merged commit d6ee2be into chainloop-dev:main Nov 18, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants