Double transform fix for modular ships / Fix mirrored parts of modular ships - #99
Merged
Merged
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
CCPNobody
reviewed
Sep 24, 2026
CCPNobody
previously approved these changes
Sep 28, 2026
ccp-intern
changed the title
Fixing incorrect merge
filipppavlov
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://fenriscreations.atlassian.net/browse/PLAT-12078
Fixed the issue: Modular ships build with EveSOF::BuildChild apply transformations twice to attachments, effect children, nested layouts and audio.
Last commit only. The other changes are part of #93
The following changes from #93 are merged into this PR:
https://fenriscreations.atlassian.net/browse/PLAT-12004
Fixes mirrored parts on modular ships:
Decomposes matrix based on determinant, with (hopefully) safe mirror axis chosen by callers
Reverse winding helper in TriGeometryRes to dry code
Instanced meshes have lod indices with reverse winding and create separate batches
Reverse quad index buffer in Tr2Renderer, used by haze and boosters
Light radius and bounding sphere calculation with absolute values
BuildChild passes scale/rotation/translation so that roundtrip through Decompose doesn't kill negative scale