Skip to content

Update rspack-plugin installation commands with version - #1460

Open
retyui wants to merge 2 commits into
mainfrom
retyui-patch-1
Open

retyui wants to merge 2 commits into
mainfrom
retyui-patch-1

Conversation

@retyui

@retyui retyui commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Summary

A fresh new Re.Pack (rspack) project won't work it you add @rsdoctor/rspack-plugin@1.3.12+

Build crash with the next errors:

npx react-native bundle --platform ios

        
Rsdoctor v1.6.0+

error Given napi value is not an array on NapiResolveOptions.fallback.
Error: Given napi value is not an array on NapiResolveOptions.fallback
    at interceptLoader (file:///Users/xd/tmp/RepackApp/node_modules/@rsdoctor/core/dist/inner-plugins/utils/loader.js:44:28)
    at InternalLoaderPlugin.getInterceptRules (file:///Users/xd/tmp/RepackApp/node_modules/@rsdoctor/core/dist/inner-plugins/plugins/loader.js:91:16)
    at InternalLoaderPlugin.afterPlugins (file:///Users/xd/tmp/RepackApp/node_modules/@rsdoctor/core/dist/inner-plugins/plugins/loader.js:110:54)
    at Object.fn (/Users/xd/tmp/RepackApp/node_modules/@rspack/core/dist/index.js:10438:29)
    at SyncHook.callAsyncStageRange (/Users/xd/tmp/RepackApp/node_modules/@rspack/lite-tapable/dist/index.cjs:238:21)
    at SyncHook.callStageRange (/Users/xd/tmp/RepackApp/node_modules/@rspack/lite-tapable/dist/index.cjs:256:14)
    at SyncHook.call (/Users/xd/tmp/RepackApp/node_modules/@rspack/lite-tapable/dist/index.cjs:251:21)
    at RspackOptionsApply.process (/Users/xd/tmp/RepackApp/node_modules/@rspack/core/dist/index.js:10139:623)
    at createCompiler (/Users/xd/tmp/RepackApp/node_modules/@rspack/core/dist/index.js:10179:160)
    at create (/Users/xd/tmp/RepackApp/node_modules/@rspack/core/dist/index.js:10205:28)

Rsdoctor v1.5.0

✖ [14:38:17.583Z][LoggerPlugin]

Rsdoctor v1.4.0

✖ [14:38:17.583Z][LoggerPlugin]

Rsdoctor v1.3.12

✖ [14:37:13.135Z][LoggerPlugin] 
BadRequestError: request aborted
    at IncomingMessage.onAborted (file:///Users/xd/tmp/RepackApp/node_modules/@rsdoctor/sdk/dist/index.js:4113:34)
    at IncomingMessage.emit (node:events:508:28)
    at IncomingMessage._destroy (node:_http_incoming:221:10)
    at _destroy (node:internal/streams/destroy:122:10)
    at IncomingMessage.destroy (node:internal/streams/destroy:84:5)
    at abortIncoming (node:_http_server:845:9)
    at socketOnClose (node:_http_server:839:3)
    at Socket.emit (node:events:520:35)
    at TCP.<anonymous> (node:net:346:12)


Test plan

1. Create a new project (rspack): https://re-pack.dev/docs/getting-started/quick-start
2. Add Bundle analysis : https://re-pack.dev/docs/guides/bundle-analysis

@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
repack-website Ready Ready Preview Sep 16, 2026 2:37pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Sep 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d574a86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dannyhw

dannyhw commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Any idea why? We had a fix for rsdoctor recently maybe its related?

@retyui

retyui commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

@dannyhw as I see rust native function expected fallback to be an array, but received an object

/// error Given napi value is not an array on NapiResolveOptions.fallback.
fallback: { item: 'str'    } // < - now
fallback: { item: ['str'] } // < - expected by napi
Screenshot 2026-09-16 at 17 09 10

to debug:

node --inspect-brk ./node_modules/.bin/react-native bundle \
                              --entry-file index.js \
                              --platform ios \
                              --dev false \
                              --bundle-output ios/main.jsbundle \
                              --assets-dest ios/assets --reset-cache

@retyui

retyui commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

@dannyhw I guess this fix need to be released e283ccf

This branch was successfully deployed

1 active deployment
Preview d574a86d Deployed Sep 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants