Skip to content

fix(ui): the end stays in view when the dock grows (D-258) - #239

Merged
blove merged 1 commit into
mainfrom
blove/dock-keeps-end-in-view
Nov 20, 2026
Merged

blove merged 1 commit into
mainfrom
blove/dock-keeps-end-in-view

Conversation

@blove

@blove blove commented Nov 20, 2026

Copy link
Copy Markdown
Contributor

What

The request cards, the continuity banner, an error and the composer are docked under the transcript, so each takes its height from the transcript's viewport. When an approval card arrived, the message just sent and the last lines above it went out of sight under the card. The transcript kept its end in view when its content changed size, and did nothing when its viewport got shorter.

Now, when the viewport gets shorter and nothing holds the view, TranscriptView goes back to the end. A reader who scrolled back, or who holds a turn open, stays where they are. The layout pass that shortens the viewport moves the view down and up again before it rests; that upward move is no longer read as the reader scrolling back.

The card stays docked: the owner chose this over drawing it inline in the transcript or in place of the composer.

Evidence

  • Seen on screen in the Local build from main (2d5395f) with a Claude Code approval card.
  • TranscriptScrollTests.theEndStaysInViewWhenTheDockGrows (hosted in a window) failed before the change with the end out of view and passes after; aGrowingDockLeavesAReaderWhoScrolledBack covers the reader who scrolled back.

Gates

  • WorkspaceStorageTests + CoordinatorTests: 529 tests in 68 suites passed.
  • Everything else: 1740 tests in 187 suites, one failure, TranscriptScrollTests.openingATurnLeavesItsLineWhereItWas, timed out waiting for the transcript to settle with the machine's load average above 100. The same test timed out the same way before this change (noted in fix(coordinator): an answered turn is running again at once (D-257) #238). Its two suites passed three reruns in a row with this change in.
  • swift format lint --strict and Scripts/docs-index.sh --check clean.

Not checked

The fix on screen in a rebuilt app; the phone, where the keyboard also shortens the viewport.

🤖 Generated with Claude Code

A request card, an error or a taller draft shortens the transcript's
viewport. A reader at the end is taken back to the end; a reader who
scrolled back stays where they are.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@blove
blove enabled auto-merge November 20, 2026 01:16
@blove
blove added this pull request to the merge queue Nov 20, 2026
blove added a commit that referenced this pull request Nov 20, 2026
#239 takes D-258 and #240 takes D-259.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged via the queue into main with commit fe52e2e Nov 20, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant