Repository navigation
fix(ui): the end stays in view when the dock grows (D-258) - #239
Merged
Merged
Conversation
A request card, an error or a taller draft shortens the transcript's viewport. A reader at the end is taken back to the end; a reader who scrolled back stays where they are. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
blove
enabled auto-merge
November 20, 2026 01:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The request cards, the continuity banner, an error and the composer are docked under the transcript, so each takes its height from the transcript's viewport. When an approval card arrived, the message just sent and the last lines above it went out of sight under the card. The transcript kept its end in view when its content changed size, and did nothing when its viewport got shorter.
Now, when the viewport gets shorter and nothing holds the view,
TranscriptViewgoes back to the end. A reader who scrolled back, or who holds a turn open, stays where they are. The layout pass that shortens the viewport moves the view down and up again before it rests; that upward move is no longer read as the reader scrolling back.The card stays docked: the owner chose this over drawing it inline in the transcript or in place of the composer.
Evidence
TranscriptScrollTests.theEndStaysInViewWhenTheDockGrows(hosted in a window) failed before the change with the end out of view and passes after;aGrowingDockLeavesAReaderWhoScrolledBackcovers the reader who scrolled back.Gates
WorkspaceStorageTests+CoordinatorTests: 529 tests in 68 suites passed.TranscriptScrollTests.openingATurnLeavesItsLineWhereItWas, timed out waiting for the transcript to settle with the machine's load average above 100. The same test timed out the same way before this change (noted in fix(coordinator): an answered turn is running again at once (D-257) #238). Its two suites passed three reruns in a row with this change in.swift format lint --strictandScripts/docs-index.sh --checkclean.Not checked
The fix on screen in a rebuilt app; the phone, where the keyboard also shortens the viewport.
🤖 Generated with Claude Code