Skip to content

Add Agent Protocol client foundation and account lifecycle safeguards - #180

Draft
blove wants to merge 152 commits into
mainfrom
blove/protocol-client-foundation-f9a-20261111
Draft

blove wants to merge 152 commits into
mainfrom
blove/protocol-client-foundation-f9a-20261111

Conversation

@blove

@blove blove commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Scope

Stage Agent Protocol connections behind activation gates. Preserve cached historical B4 conversations, drafts, pending requests and unknown outcomes. Add Foundation transports, account-bound storage and owner controls. New profiles refuse execution while coordinated activation is pending.

Compatibility

Integrated main through D-259. The published turn migrations retain Store16, Hub23 and Mirror11. Protocol storage follows at Store17 and Hub24. The restore cases cover a published format-3 Store16 archive with nondefault turn fields, defaults on earlier stores, and rejection of the unpublished protocol16 alias. The phone advertises protocol 1 on HTTP and relay until its mirror can retain protocol records. The coordinator advertises 2.

Verification

Everyday CI uses the exact workflow from main and runs all database cases on Swift Testing’s standard executor. The temporary qualification additionally uses the native per-case executor, focused native and compiler checks, and bounded and serial database aggregates. At 8c5b3d74 with main 4c30a194, all four qualification jobs passed, including the bounded and serial aggregates. Everyday CI passed nine jobs. The package completed its three test invocations: 967 database tests reported 38 issues, 1,907 non-database tests reported 24 issues from three timed Node probe cases, and all eight parser timing tests passed. Both phone cursor-preservation cases passed. The PR remains draft while the everyday failures are open. Everyday CI · Pre-merge qualification

At d3305a10 all four separate qualification jobs passed. Everyday CI passed nine jobs. The package log recorded system-wide file descriptor exhaustion during parallel database startup, followed by PostgreSQL recovery. This revision confines the PR-specific executor to the qualification run while preserving every test. Previous everyday CI · Previous qualification

At c6f4186d the focused controls passed, and both database aggregates completed 967 tests with the same single stale migration assertion. The everyday run passed nine jobs. GitHub marked the package job cancelled after its time limit and omitted its raw log. Previous everyday CI · Previous qualification

The pre-integration head passed all eleven hosted jobs before the published turn migrations were integrated. Earlier package timeouts and serial results remain in the run history. Previous green run

After green review, use the normal squash merge queue and verify the merge group and merged main. Retire PR-specific qualification scheduling and its dedicated tests in a follow-up while preserving lasting behavioral regressions. Publication, deployment, coordinated activation, A4–A10 and live HTTP remain held.

blove added 30 commits November 11, 2026 18:39
blove and others added 19 commits November 17, 2026 20:56
Restore fixture preconditions and displayed-text assertions. Preserve owned-log polling and optional adapter capabilities.

Add bounded observations at command, migration, and shutdown boundaries while retaining existing operation budgets and joins.
Merge current approval-choice behavior while preserving read-only historical requests and native smoke controls.

Use an explicit Sendable closure type for the cleanup observer.
Preserve current main's terminal-note behavior and fixture checks. Give the
selected migration and socket shutdown cases private execution resources,
and trace existing command children and selected outcomes. Preserve native
scenario budgets, command results and real cleanup joins.
Give database test cases dedicated executor resources and preserve explicit
fixture operation joins under contention. Keep test assertions, deadlines
and CI coverage intact.
Match the shipped concurrency contract and keep every owner fixture
executor alive through its existing cleanup joins.
Integrate the reviewed main changes while retaining authoritative request routing and stale-read guards. Keep native lease control independent of test-task scheduling, observe backend cleanup within a bounded window, and expose closed writer prerequisite diagnostics without changing its semantics.

Preserve existing test identities, parameters, commands and time limits; add request settlement regressions. Fresh managed validation follows this upload.
Preserve request assertions and cleanup diagnostic text while addressing the strict Swift format diagnostics.

Validation: independent source review and exact two-file scope; managed format and native CI remain pending.
Preserve native request admission and historical actions while integrating main transcript follow behavior. Retire send counters with account state and keep the incoming send fixtures valid under the runtime guard.

Validation: complete source inventory and independent source review passed; fresh managed CI and focused native/compiler controls remain required.
Align the compiler manifest guard and add a root-byte regression check. Extend the existing bounded backend observation to two cleanup assertions. Add closed cancellation reason, immediate raw-query duration and owning-test attribution while preserving the legacy record, redacted failure, transaction behavior and execution settings.

Integrate current main activity rows with native approval and historical-cache smoke coverage. Preserve branch-owned guards, test identities and all reviewed source pins.

Source specification and independent quality reviews passed. Fresh managed CI remains required for runtime validation.
Apply the required line break while preserving the selector and every test assertion.
Move two held migration-test controls onto retained native controllers while preserving their limits, ordering and assertions. Add closed rendered-context and partial per-case queue observations to existing writer failures without changing SQL, scheduling policy or issue count.

Document the verified focused-native results and remaining database failures, and refresh the affected source pins. Fresh managed CI remains required.
Use fixed table names for known fixture comparisons within the existing default-collation caller domain. Preserve whole-image, duplicate and fallback assertions, and refresh the source-bound compiler pins.

Record the existing Node probe snapshot for the development-mode fixture without changing probe behavior or budgets. Document the completed serial comparison and remaining parallel failures.
#239 takes D-258 and #240 takes D-259.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@blove blove added the qualify-pr-180 Run protocol pre-merge qualification on the reviewed PR 180 revision label Nov 20, 2026
@blove blove added qualify-pr-180 Run protocol pre-merge qualification on the reviewed PR 180 revision and removed qualify-pr-180 Run protocol pre-merge qualification on the reviewed PR 180 revision labels Nov 20, 2026
@blove blove added qualify-pr-180 Run protocol pre-merge qualification on the reviewed PR 180 revision and removed qualify-pr-180 Run protocol pre-merge qualification on the reviewed PR 180 revision labels Nov 20, 2026
@blove blove added qualify-pr-180 Run protocol pre-merge qualification on the reviewed PR 180 revision and removed qualify-pr-180 Run protocol pre-merge qualification on the reviewed PR 180 revision labels Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

qualify-pr-180 Run protocol pre-merge qualification on the reviewed PR 180 revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant