Repository navigation
chore(extension): version 1.1.1, packaged only from main - #105
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 1.1.0 in the Chrome Web Store does not have #100. Its zip was packaged from
chore/extension-1.1.0before #100 merged, so its manifest has noexternally_connectable. jlog.ai'sjlog:signed-inandjlog:signed-outmessages are refused,send()reads that as "not installed", and the extension stays on whichever account it last had. Seen in practice: the extension onhello@bhargav.dev, the dashboard on the GitHub account.main.pnpm --filter @jlog/extension packagenow refuses unless the checkout is clean and HEAD isorigin/main(it fetches first), and prints the commit it built. A zip from another branch could carry the right version number and miss what was merged under it, which is how 1.1.0 shipped.Checked on this branch: the packager refuses with uncommitted changes, then refuses again because HEAD is not
origin/main. A plainvite buildemits version 1.1.1 withexternally_connectable: { matches: ["https://jlog.ai/*"] }. Extension tests (116) and typecheck pass.After merging: run the packager on
main, uploadjlog-extension.zip, and once 1.1.1 is live, signing in or out on jlog.ai should move the extension with it.