Pin zero_mean in conn_spec's TF decomposition; test CI on Python 3.10… - #70
Merged
Merged
Conversation
…-3.12 - _tf_decomp: mne changed the default of `zero_mean` in tfr_array_morlet / tfr_array_multitaper from False (<=1.5) to True, so conn_spec results silently depended on the installed mne version. Set zero_mean=False explicitly (user values in kw_cwt / kw_mt take precedence) and pin it in the conn_spec reference tests as well. - CI: Python matrix 3.8/3.9 -> 3.10/3.11/3.12 (mne >= 1.13 requires Python >= 3.11), flake / doc jobs on 3.11, classifiers updated. - What's new: conn_spec fixes from PR #69 and the Python / mne range. Verified with the full test suite at both ends of the supported range: Python 3.10 + mne 1.5.0 and Python 3.12 + mne 1.13.2 + numpy 2.5.3. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The doc build failed on the new CI matrix (Python 3.10 / 3.11 / 3.12)
while pytest passed:
Extension error: Could not import extension sphinxcontrib.bibtex
(cannot import name 'MutableSet' from 'collections')
sphinxcontrib-bibtex was pinned to 1.0.0 (2019), which depends on `oset`
and its `collections.MutableSet` import, an alias removed in Python 3.10.
This is why the build only ever passed on the old 3.8 / 3.9 matrix.
- setup.py: sphinxcontrib-bibtex>=2.6 and sphinx>=7.4 (bibtex 2.7 needs
it; the sphinx==7.0.0 pin is lifted, the build is verified with Sphinx
7.4.7 and 9.0.4)
- conf.py: intersphinx_mapping in the named format required by Sphinx
>= 8 (the pre-1.0 format was rejected with a ConfigError), language
'en' instead of None
- what's new: the extlink role is :pull:, not :PR:
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
On the Python 3.12 CI job, 31 of the 34 gallery examples failed with
ModuleNotFoundError: No module named 'pkg_resources'
raised by frites.set_mpl_style, which every example calls first.
pkg_resources belongs to setuptools, which is no longer installed by
default in Python >= 3.12 environments and whose pkg_resources module is
deprecated. Locate the .mplstyle files with the stdlib
importlib.resources instead (Python >= 3.9).
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…-3.12
zero_meanin tfr_array_morlet / tfr_array_multitaper from False (<=1.5) to True, so conn_spec results silently depended on the installed mne version. Set zero_mean=False explicitly (user values in kw_cwt / kw_mt take precedence) and pin it in the conn_spec reference tests as well.Verified with the full test suite at both ends of the supported range: Python 3.10 + mne 1.5.0 and Python 3.12 + mne 1.13.2 + numpy 2.5.3.
Thanks for contributing a pull request!
Please be aware that we are a loose team of volunteers so patience is
necessary. Assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
Again, thanks for contributing!
Reference issue
Example: Fixes #1234.
What does this implement/fix?
Explain your changes.
Additional information
Any additional information you think is important.