Repository navigation
Fix MSSQL apply order and compare for NAV-style object names - #68
Merged
Merged
Conversation
…accents (#64) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #64 (item 3), bumps to 0.17.2.
Found by running a NAV-like schema (names like
[Company$Cust_ Ledg_ Entry é]) through apply, introspect and compare on a real SQL Server:exp.table_nameand never matched the file-derived names, so views were applied before their tables.compare:decimal(38,20)vsnumeric(38, 20), bracket-quoted index columns, index names with spaces, and nested-paren filters (([b]>(1))) gave false diffs.Measured with 1,950 tables and 4,500 views: apply 17 s, parse 2.3 s, introspect 6.4 s, diff 0.4 s, 98 MB RSS, 0 diffs. Introspection runs several queries per table, so against a remote server it is latency-bound (not changed). Views are introspected and compared;
update-statsquotes names correctly (live test added).🤖 Generated with Claude Code
Claude Session: 928b2739-5a21-5fd4-b2a1-23bb76c373be