Repository navigation
Hide secrets from logging output - #104
Merged
Merged
Conversation
Assisted-by: oh-my-pi:claude-opus-5.5
tacaswell
approved these changes
Nov 8, 2026
Contributor
|
Since we are preparing to extend logging capabilities, we may need more robust solution that prevents accidental printing. For example, the secrets can be represented as Tiled is currently using SecretStr to store access token https://github.com/bluesky/tiled/blob/49fe22daae308237470d739b2f87622319f4e81c/tiled/server/schemas.py#L432, the other secrets are stored as strings, so they potentially can leak into logs. @genematx |
Contributor
Author
|
Can we merge this in the interim? @dmgav |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The startup log currently dumps the full Settings object, which can include single_user_api_key and secret_keys. Redact those fields so they do not appear in logs.