[TASK] Pin the workflows to ubuntu-24.04 - #2
Closed
benjaminkott wants to merge 1 commit into
Closed
benjaminkott wants to merge 1 commit into
benjaminkott wants to merge 1 commit into
Conversation
Every run on main and the release of 0.5.0 carried the same annotation: the ubuntu-latest label migrates to Ubuntu 26 on 19 October 2026. Both workflows install Chromium's system libraries through Playwright, and which image those land on should be a decision made in the workflow, not one made by a calendar -- least of all on a release, which would be the first run to find out. Both jobs now name the image. Moving to the next one is a one-line change made on purpose, with a CI run to say whether it holds. Signed-off-by: Benjamin Kott <benjamin.kott@outlook.com>
Owner
Author
|
Not wanted: the runner should follow ubuntu-latest, and the dependencies are to be kept current instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every run on
mainand the release of 0.5.0 carried the annotation thatubuntu-latestmigrates to Ubuntu 26 on 19 October 2026. Both workflows install Chromium's system libraries through Playwright, so the image they run on should be named in the workflow rather than decided by a date — least of all on a release run.Both jobs now say
ubuntu-24.04. Moving on is a one-line change made on purpose, with a CI run to say whether it holds.Type of change
Related issues
How to validate
gh api repos/benjaminkott/diffyard/actions/runs/<run>/jobs --jq '.jobs[].labels[]'saysubuntu-24.04AI assistance
Checklist
maingit commit -s) — appreciated, notrequired
[BUGFIX|TASK|FEATURE] Subjectnpm run typecheckpassesnpm testpassesnot required
changed