Skip to content

docs: state the default drop grace of a week on the agents page - #140

Merged
AlexeyShalaev merged 1 commit into
masterfrom
docs/default-drop-grace
Nov 11, 2026
Merged

AlexeyShalaev merged 1 commit into
masterfrom
docs/default-drop-grace

Conversation

@AlexeyShalaev

Copy link
Copy Markdown
Member

The agents page contradicted itself on the default lifecycle. The paragraph under the policy example said LifecyclePolicy() uses DropAfter(grace=timedelta(0)) and "detaches and drops in the same run". Rule 8 said the default drops a week after the detach.

The code agrees with rule 8:

  • LifecyclePolicy.drop defaults to DropAfter(grace=timedelta(days=DEFAULT_DROP_GRACE_DAYS)), and DEFAULT_DROP_GRACE_DAYS = 7.
  • LifecyclePolicy() prints drop=DropAfter(kind='drop_after', grace=datetime.timedelta(days=7), when=None).

The paragraph now says the same as the code and rule 8. It also notes that a bare DropAfter() is the one that drops in the same run. An agent reading only that paragraph would have expected partitions to vanish on the first run, or would have added a needless DropAfter(grace=...).

@codecov

codecov Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@AlexeyShalaev
AlexeyShalaev merged commit eb29d57 into master Nov 11, 2026
60 of 62 checks passed
@AlexeyShalaev
AlexeyShalaev deleted the docs/default-drop-grace branch November 11, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant