Skip to content

Bugfix/devsu 2900 fix reference handling for eligibility type statements with nct sources - #127

Open
sshugsc wants to merge 6 commits into
developfrom
bugfix/DEVSU-2900-fix-reference-handling-for-eligibility-type-statements-with-nct-sources
Open

sshugsc wants to merge 6 commits into
developfrom
bugfix/DEVSU-2900-fix-reference-handling-for-eligibility-type-statements-with-nct-sources

Conversation

@sshugsc

@sshugsc sshugsc commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

DEVSU-2900:

  • set reference to be nctId when evidence is from clinicaltrials.gov
  • test update

@sshugsc
sshugsc requested review from elewis2 and a balanced review from Copilot October 27, 2026 22:50
@sshugsc sshugsc self-assigned this Oct 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The updated tests remove eligibility-specific regression coverage for the case this fix targets.

1 open issue
What changed in this PR

This PR updates IPR reference conversion for DEVSU-2900 so ClinicalTrials.gov evidence uses its trial identifier rather than selecting references based on statement relevance.

Changes:

  • Use sourceId for ClinicalTrials.gov trial evidence and displayName for other evidence.
  • Update fixtures and reference assertions to include mixed publication and clinical-trial evidence.
File Description
tests/​test_ipr/​test_ipr.py Updates evidence fixtures and reference-conversion tests.
pori_python/​ipr/​ipr.py Selects references using each evidence record's class and source.

Review effort: Balanced

Comment thread tests/test_ipr/test_ipr.py Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants