Repository navigation
Bugfix/devsu 2900 fix reference handling for eligibility type statements with nct sources - #127
Open
sshugsc wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated tests remove eligibility-specific regression coverage for the case this fix targets.
1 open issue
What changed in this PR
This PR updates IPR reference conversion for DEVSU-2900 so ClinicalTrials.gov evidence uses its trial identifier rather than selecting references based on statement relevance.
Changes:
- Use
sourceIdfor ClinicalTrials.gov trial evidence anddisplayNamefor other evidence. - Update fixtures and reference assertions to include mixed publication and clinical-trial evidence.
| File | Description |
|---|---|
| tests/test_ipr/test_ipr.py | Updates evidence fixtures and reference-conversion tests. |
| pori_python/ipr/ipr.py | Selects references using each evidence record's class and source. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

DEVSU-2900: