Skip to content

Fix incorrect model_trainer method call to load hyperparameters from file - #5771

Open
admivsn wants to merge 3 commits into
aws:masterfrom
admivsn:fix-model-trainer-nova-recipe-hyperparameter-file-bug
Open

admivsn wants to merge 3 commits into
aws:masterfrom
admivsn:fix-model-trainer-nova-recipe-hyperparameter-file-bug

Conversation

@admivsn

@admivsn admivsn commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Issue #5770

Description of changes:
Using incorrect method name when loading hyperparameters from file

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

mohamedzeidan2021 and others added 2 commits October 5, 2026 11:04
Regression tests for the AttributeError in aws#5770: from_recipe() called a
non-existent _validate_and_load_hyperparameters_file when hyperparameters
was a path string. Cover JSON and YAML files, the dict path, and a missing
file, all of which fail with AttributeError before the one-line fix.

This branch is waiting to be deployed

1 waiting deployment
manual-approval — e5ab355f Waiting Oct 5, 2026 by mohamedzeidan2021 via wait-for-approval #536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants