build: include LICENSE and NOTICE in published JARs - #2450
Merged
mykola-mokhnach merged 1 commit intoSep 25, 2026
Merged
mykola-mokhnach merged 1 commit into
mykola-mokhnach merged 1 commit into
Conversation
dlowzzxx
requested review from
SrinivasanTarget,
mykola-mokhnach,
saikrishna321 and
valfirst
as code owners
September 23, 2026 19:43
|
|
mykola-mokhnach
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change list
LICENSEandNOTICEtoMETA-INFin the three Maven-published JARs (binary, sources, and Javadoc), so release consumers get Appium's Apache 2.0 and copyright notices in each artifact.Types of changes
Details
Fixes #2448 for the Maven-published artifacts. The published
io.appium:java-client:10.1.1binary JAR has 640 entries but contains noLICENSEorNOTICEat any path. The Gradle build publishescomponents.javawithout copying either root file into its three archives. The change configuresjar,sourcesJar, andjavadocJarto place both files atMETA-INF/LICENSEandMETA-INF/NOTICE. The optionalshadowJartask is not part of that Maven publication and remains unchanged; its dependency notice files require separate handling.Verification: The published
10.1.1binary and sources JARs contain no license or notice file; its Javadoc JAR has only a generatedlegal/LICENSE, with noMETA-INF/LICENSEorMETA-INF/NOTICE. In a Gradle 9.7.1/JDK 25 Linux container,gradle jar sourcesJar javadocJar --offline --no-daemon --console=plainsucceeded. Direct ZIP inspection found exactly oneMETA-INF/LICENSEand oneMETA-INF/NOTICEin each of the three new JARs, byte-for-byte equal to the repository files.git diff --checkpasses.Codex assisted with investigation, implementation, and verification. If this merged contribution qualifies for Appium's discretionary contributor compensation, I would appreciate consideration under the governance policy and can provide payout details privately through OpenCollective. No payment is assumed.