ADFA-6371: Make the selected toggle button visible in new-file dialogs - #2102
Daniel-ADFA wants to merge 1 commit into
Conversation
Material 3 fills a checked outlined button with colorSecondaryContainer, which the theme sets to #E8E8E8 on a #EDEDED dialog, and keeps the text colour, so selecting Kotlin or a class type showed no change. The theme now points materialButtonOutlinedStyle at a style that fills checked buttons with colorPrimary and draws their text and icon in colorOnPrimary; unchecked and non-toggle buttons keep Material's colours. The Class button also switches to the Kotlin icon when Kotlin is picked.
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (4)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 Summary
WalkthroughThe file dialog updates its class-type icon based on the selected language. The styled theme adds an outlined-button style with state-based background, text, and icon colors. ChangesFile dialog icon
Outlined button theme
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The icon follows the selected language, and unchecked outlined buttons retain their Material colors. No identified issue remains that should delay merging. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
A rabbit spots Kotlin, then Java in view, Comment |
ADFA-6371
Selected toggle buttons were filled with
colorSecondaryContainer(#E8E8E8 on a #EDEDED dialog) with unchanged text, so picking Kotlin or a class type showed no change. The theme'smaterialButtonOutlinedStylenow fills checked buttons withcolorPrimaryand usescolorOnPrimaryfor text and icon; unchecked and non-toggle buttons keep Material's colours. The Class icon now follows the selected language.Set at theme level, so the C/C++ dialog in #2101 picks it up too. Not yet checked on device.