chore(docker): bump builder image to golang:1.26.8 - #401
Merged
Merged
Conversation
Contributor
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Go 1.26.7 fixes the unencrypted HTTP/2 regression from the 1.26.6 security patch (Go issue 80876). 1.26.8 is the current 1.26 bugfix. Co-authored-by: Siddharth Kothari <siddharthlatest@gmail.com>
cursor
Bot
force-pushed
the
cursor/bump-golang-1-26-8-04d7
branch
from
September 28, 2026 13:06
4a4b192 to
e775e07
Compare
Contributor
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
Set the default release version baked into the binary via -X main.Version. Go, module, and dependency versions are unchanged. Co-authored-by: Siddharth Kothari <siddharthlatest@gmail.com>
Contributor
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Bumps the Docker builder image from
golang:1.26.6togolang:1.26.8, and sets the shipped app version from 9.4.0 to 9.4.1.Go 1.26.7 fixes an unencrypted HTTP/2 regression introduced by the 1.26.6 security patch (Go issue 80876). 1.26.8 is the current 1.26 bugfix. This stays on the 1.26 line.
ARG VERSIONinDockerfileandDEFAULT_VERSIONinMakefileare the only 9.4.0 pins. That string is baked into the binary with-X main.Version.go.modand CI remain on Go 1.25.14. Dependency versions are unchanged. No tag and no GitHub release.What should your reviewer look out for in this PR?
DockerfileFROM golang:1.26.8DockerfileARG VERSION=9.4.1MakefileDEFAULT_VERSION=9.4.1Rebased onto
devafter #397. The dependency bumps from that merge stay in place.Which issue(s) does this PR fix?
If this PR affects any API reference documentation, please share the updated endpoint references
No API changes.